Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinappDebug] Detect if other entries are the same #410

Open
ROCKNROLLKID opened this issue Oct 12, 2019 · 1 comment
Open

[WinappDebug] Detect if other entries are the same #410

ROCKNROLLKID opened this issue Oct 12, 2019 · 1 comment
Assignees

Comments

@ROCKNROLLKID
Copy link
Collaborator

@ROCKNROLLKID ROCKNROLLKID commented Oct 12, 2019

This was discussed here: #408

Currently, WinappDebug only detects if entries are the same within the same entry, but not if other entries are the same. So basically, if I made a entry with %SystemDrive%|.log and another entry that had %SystemDrive%|.log, WinappDebug would NOT detect this, however if I made a entry with both %SystemDrive%|*.log, then WinappDebug WOULD detect it.

I just opened this so it wouldn't be forgotten, but if it is too much work or if it causes too many false positives or some other issue, we can just forget it.

@MoscaDotTo
Copy link
Owner

@MoscaDotTo MoscaDotTo commented Oct 13, 2019

I can envision this working with two settings

"strict" mode, where the keys' parameters must be identical (ie %SystemDrive%|*.log and %SystemDrive%|*.log* would not match

and "warning" mode, where just identical folders would match (ie. the example above would match) - this would bear mostly false positives but would probably also eliminate most false negatives

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants