Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Sidebar not closing when clicking in Home or Directory on mobile view #23218

Merged
merged 6 commits into from Sep 24, 2021

Conversation

@dougfabris
Copy link
Member

@dougfabris dougfabris commented Sep 16, 2021

Proposed changes (including videos or screenshots)

Additional fixed

  • Merge Burger menu components into a single component
  • Show a badge with no-read messages in the Burger Button:
    image
  • remove useSidebarClose hook

Issue(s)

Steps to test or reproduce

  • Click in Home and Directory buttons in sidebar using a mobile browser

Further comments

Copy link

@github-actions github-actions bot left a comment

You have added 1 .js files, please convert to ts(x).
client/components/BurgerMenu/BurgerMenu.stories.js

@github-actions github-actions bot dismissed their stale review Sep 16, 2021

js files removed

@dougfabris dougfabris changed the title [FIX] Home and Directory doesn't open when clicked on mobile view [FIX] Sidebar not closing when clicking in Home or Directory on mobile view Sep 16, 2021
@dougfabris dougfabris requested a review from Sep 16, 2021
ggazzo
ggazzo approved these changes Sep 24, 2021
@ggazzo ggazzo merged commit 370a7b9 into develop Sep 24, 2021
17 checks passed
@ggazzo ggazzo deleted the fix/mobile-directory-and-home branch Sep 24, 2021
@sampaiodiego sampaiodiego mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants