Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OPUS from supported HLS audio formats #2672

Merged
merged 1 commit into from May 26, 2021

Conversation

@nyanmisaka
Copy link
Member

@nyanmisaka nyanmisaka commented May 18, 2021

Changes

  • Remove OPUS from supported HLS audio formats

OPUS is not a standard HLS audio format, it's not mentioned in Apple's HLS document.
Remuxing/Direct Streaming films with OPUS audio to Android Chrome will result in no sound.
Thus leave it only for DirectPlay and Tizen.

Issues
Fixes jellyfin/jellyfin#5116

@nyanmisaka nyanmisaka added this to Active PRs in Current Release May 18, 2021
@cvium
cvium approved these changes May 18, 2021
@dmitrylyzo
Copy link
Contributor

@dmitrylyzo dmitrylyzo commented May 18, 2021

Couldn't it be that Samsung and LG support it despite the standard (as it is with HEVC in TS)?

OPUS is not a standard HLS audio format, it's not mentioned in Apple's HLS document.
Remuxing/Direct Streaming films with OPUS audio to Android Chrome will result in no sound.
Thus leave it only for DirectPlay and Tizen.
@nyanmisaka nyanmisaka force-pushed the nyanmisaka:patch-1 branch from 3a6d6ab to 1fc5096 May 19, 2021
@nyanmisaka
Copy link
Member Author

@nyanmisaka nyanmisaka commented May 19, 2021

Couldn't it be that Samsung and LG support it despite the standard (as it is with HEVC in TS)?

OPUS has been disabled on WebOS in the code.
I don't have a Samsung TV to test but OPUS is supported in TS as per their docs. I will leave it only for Tizen.

@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented May 19, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@thornbill thornbill merged commit 95256a8 into jellyfin:master May 26, 2021
16 checks passed
16 checks passed
@github-actions
Analyze (javascript)
Details
@github-actions
Run eslint
Details
@github-actions
triage
Details
@github-actions
Run stylelint (css)
Details
@github-actions
Run stylelint (scss)
Details
@github-code-scanning
CodeQL No new or fixed alerts
Details
@azure-pipelines
Jellyfin Web Build #20210519.1 succeeded
Details
@azure-pipelines
Jellyfin Web (Build Development) Build Development succeeded
Details
@azure-pipelines
Jellyfin Web (Build Docker) Build Docker succeeded
Details
@azure-pipelines
Jellyfin Web (Build Packages CentOS) Build Packages CentOS succeeded
Details
@azure-pipelines
Jellyfin Web (Build Packages Debian) Build Packages Debian succeeded
Details
@azure-pipelines
Jellyfin Web (Build Packages Fedora) Build Packages Fedora succeeded
Details
@azure-pipelines
Jellyfin Web (Build Packages Portable) Build Packages Portable succeeded
Details
@azure-pipelines
Jellyfin Web (Build Production) Build Production succeeded
Details
@azure-pipelines
Jellyfin Web (Collect Artifacts) Collect Artifacts succeeded
Details
@sonarcloud
SonarCloud Code Analysis Quality Gate passed
Details
Current Release automation moved this from Active PRs to Completed PRs May 26, 2021
@nyanmisaka nyanmisaka deleted the nyanmisaka:patch-1 branch May 27, 2021
joshuaboniface added a commit that referenced this pull request May 27, 2021
Remove OPUS from supported HLS audio formats

(cherry picked from commit 95256a8)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Current Release May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Current Release
  
Jellyfinished
Linked issues

Successfully merging this pull request may close these issues.

6 participants