Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code duplication: DeepCopy and CopyProperties #5096

Open
Bond-009 opened this issue Jan 24, 2021 · 3 comments
Open

code duplication: DeepCopy and CopyProperties #5096

Bond-009 opened this issue Jan 24, 2021 · 3 comments
Projects

Comments

@Bond-009
Copy link
Member

@Bond-009 Bond-009 commented Jan 24, 2021

CopyProperties in Jellyfin.Api/Helpers/ClassMigrationHelper.cs
and
DeepCopy in MediaBrowser.Controller/Entities/BaseItemExtensions.cs
do basically the same thing.

@Bond-009 Bond-009 added this to To do in Cleanup via automation Jan 24, 2021
@BaronGreenback
Copy link
Contributor

@BaronGreenback BaronGreenback commented Jan 31, 2021

My bad - think I'm responsible for the top one. It's used to migrate the network settings out of system.xml and into network.xml

@BaronGreenback
Copy link
Contributor

@BaronGreenback BaronGreenback commented Mar 11, 2021

Code is removed in #5482

@stale
Copy link

@stale stale bot commented Jul 10, 2021

This issue has gone 120 days without comment. To avoid abandoned issues, it will be closed in 21 days if there are no new comments.
If you're the original submitter of this issue, please comment confirming if this issue still affects you in the latest release or nightlies, or close the issue if it has been fixed. If you're another user also affected by this bug, please comment confirming so. Either action will remove the stale label.
This bot exists to prevent issues from becoming stale and forgotten. Jellyfin is always moving forward, and bugs are often fixed as side effects of other changes. We therefore ask that bug report authors remain vigilant about their issues to ensure they are closed if fixed, or re-confirmed - perhaps with fresh logs or reproduction examples - regularly. If you have any questions you can reach us on Matrix or Social Media.

@stale stale bot added the stale label Jul 10, 2021
@Bond-009 Bond-009 added confirmed and removed stale labels Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Cleanup
  
To do
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants