Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CropWhitespace function #4988

Merged
merged 1 commit into from Apr 10, 2021
Merged

Remove CropWhitespace function #4988

merged 1 commit into from Apr 10, 2021

Conversation

@Bond-009
Copy link
Member

@Bond-009 Bond-009 commented Jan 9, 2021

Fixes #4120

@@ -1681,7 +1681,7 @@ private static async Task<MemoryStream> GetMemoryStream(Stream inputStream)
int? width,
int? height,
int? quality,
bool? cropWhitespace,
bool? cropWhitespace, // TODO: Remove

This comment has been minimized.

@nielsvanvelzen

nielsvanvelzen Jan 9, 2021
Member

Can you mark it deprecated in the other functions so it propagates to the OpenAPI spec?

This comment has been minimized.

@crobibero

crobibero Jan 9, 2021
Member

I don't see a way to mark it as deprecated. I think the parameter should just be removed if it's just ignored now.

This comment has been minimized.

@Chobocharles

Chobocharles Feb 19, 2021

@crobibero I know I'm super late to the party, but you can utilize the ObsoleteAttribute class for deprecated/obsolete items:
[Obsolete("Enter whatever message you'd like.")]

This comment has been minimized.

@crobibero

crobibero Feb 19, 2021
Member

Last time I tested, we weren’t able to put the Obsolete attribute on a parameter. You can do it on the entire controller or specific endpoints, which is what we already do.

@Bond-009
Copy link
Member Author

@Bond-009 Bond-009 commented Jan 9, 2021

/azp run

@azure-pipelines
Copy link

@azure-pipelines azure-pipelines bot commented Jan 9, 2021

Azure Pipelines successfully started running 1 pipeline(s).
@cvium
cvium approved these changes Apr 9, 2021
@Bond-009
Copy link
Member Author

@Bond-009 Bond-009 commented Apr 9, 2021

/azp run

@azure-pipelines
Copy link

@azure-pipelines azure-pipelines bot commented Apr 9, 2021

Azure Pipelines successfully started running 1 pipeline(s).
@Bond-009 Bond-009 merged commit b2fbf97 into jellyfin:master Apr 10, 2021
12 checks passed
12 checks passed
Analyze (csharp) Analyze (csharp)
Details
CodeQL No new alerts
Details
Jellyfin Server Build #20210409.29 had test failures
Details
Jellyfin Server (Build Debug) Build Debug succeeded
Details
Jellyfin Server (Build Release) Build Release succeeded
Details
Jellyfin Server (Compatibility Check Common) Compatibility Check Common succeeded
Details
Jellyfin Server (Compatibility Check Controller) Compatibility Check Controller succeeded
Details
Jellyfin Server (Compatibility Check Model) Compatibility Check Model succeeded
Details
Jellyfin Server (Compatibility Check Naming) Compatibility Check Naming succeeded
Details
Jellyfin Server (Test Linux) Test Linux succeeded
Details
Jellyfin Server (Test Windows) Test Windows succeeded
Details
Jellyfin Server (Test macOS) Test macOS succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants