Remove CropWhitespace function #4988
Merged
+6
−92
Conversation
Verified
This commit was signed with the committer’s verified signature.
| @@ -1681,7 +1681,7 @@ private static async Task<MemoryStream> GetMemoryStream(Stream inputStream) | |||
| int? width, | |||
| int? height, | |||
| int? quality, | |||
| bool? cropWhitespace, | |||
| bool? cropWhitespace, // TODO: Remove | |||
nielsvanvelzen
Jan 9, 2021
Member
Can you mark it deprecated in the other functions so it propagates to the OpenAPI spec?
Can you mark it deprecated in the other functions so it propagates to the OpenAPI spec?
crobibero
Jan 9, 2021
Member
I don't see a way to mark it as deprecated. I think the parameter should just be removed if it's just ignored now.
I don't see a way to mark it as deprecated. I think the parameter should just be removed if it's just ignored now.
Chobocharles
Feb 19, 2021
@crobibero I know I'm super late to the party, but you can utilize the ObsoleteAttribute class for deprecated/obsolete items:
[Obsolete("Enter whatever message you'd like.")]
@crobibero I know I'm super late to the party, but you can utilize the ObsoleteAttribute class for deprecated/obsolete items:
[Obsolete("Enter whatever message you'd like.")]
crobibero
Feb 19, 2021
Member
Last time I tested, we weren’t able to put the Obsolete attribute on a parameter. You can do it on the entire controller or specific endpoints, which is what we already do.
Last time I tested, we weren’t able to put the Obsolete attribute on a parameter. You can do it on the entire controller or specific endpoints, which is what we already do.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #4120