Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move studios image providers to plugin #5009

Open
wants to merge 1 commit into
base: master
from

Conversation

@MrTimscampi
Copy link
Member

@MrTimscampi MrTimscampi commented Jan 12, 2021

Changes

Moves the built-in studio artwork provider to a plugin and allow customizing the repository URL.

This is the first step towards making a Jellyfin-owned artwork repository for studios and other similar things, as well as allowing users to change the URL if they want.

Issues

.addEventListener('submit', function (e) {
Dashboard.showLoadingMsg();

ApiClient.getPluginConfiguration(PluginConfig.pluginId).then(function (config) {

This comment has been minimized.

@crobibero

crobibero Jan 12, 2021
Member

Suggested change
ApiClient.getPluginConfiguration(PluginConfig.pluginId).then(function (config) {
window.ApiClient.getPluginConfiguration(PluginConfig.pluginId).then(function (config) {

iirc ApiClient is now a part of window

This comment has been minimized.

@MrTimscampi

MrTimscampi Jan 12, 2021
Author Member

Hm, we might have to update MusicBrainz and AudioDB then, this was taken from there.

@MrTimscampi MrTimscampi force-pushed the MrTimscampi:studios-images-plugin branch from 44940fd to ae66cd8 Jan 12, 2021
<!DOCTYPE html>
<html>
<head>
<title>AudioDB</title>

This comment has been minimized.

@Ullmie02

Ullmie02 Jan 18, 2021
Member

Copy/Paste :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants