Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default webdir config from option to env var #5087

Open
wants to merge 1 commit into
base: master
from

Conversation

@heylix
Copy link

@heylix heylix commented Jan 23, 2021

While using systemd to start jellyfin.service on Fedora 33,
the service failed. After inspecting the logs, the following
output seemed relevant:

[INF] [1] Main: Web resources path: /usr/lib64/jellyfin/jellyfin-web
[…]
System.InvalidOperationException: The server is expected to host the web client, but the provided content directory is either invalid or empty: /usr/lib64/jellyfin/jellyfin-web. […]

Apparently the option doesn't get picked up by the unitfile
present if there's been an older version of jellyfin installed
(see fedora/jellyfin.service line 8).

After changing the corresponding environment variable to be
consistent in handling with the rest of the env variables in
/etc/sysconfig/jellyfin, the server starts without a hitch.

Changed the default config file for Debian, too, so both
distributions have the same default values.

Changes

Issues

While using systemd to start jellyfin.service on Fedora 33,
the service failed. After inspecting the logs, the following
output seemed relevant:

[INF] [1] Main: Web resources path: /usr/lib64/jellyfin/jellyfin-web
[…]
System.InvalidOperationException: The server is expected to host the web client, but the provided content directory is either invalid or empty: /usr/lib64/jellyfin/jellyfin-web. […]

Apparently the option doesn't get picked up by the unitfile
present if there's been an older version of jellyfin installed
(see fedora/jellyfin.service line 8).

After changing the corresponding environment variable to be
consistent in handling with the rest of the env variables in
/etc/sysconfig/jellyfin, the server starts without a hitch.

Changed the default config file for Debian, too, so both
distributions have the same default values.
@dkanada dkanada requested a review from joshuaboniface Feb 5, 2021
@joshuaboniface
Copy link
Member

@joshuaboniface joshuaboniface commented Feb 8, 2021

First thing's first, everything is already consistent in Debian, let's not change that.

Second, I'm thinking this is a misconfiguration in the jellyfin-web RPM spec, not in here. The web fils should be installed to /usr/lib[64]/jellyfin/web like on Debian, but I don't understand RPM spec files enough to see where that's happening (and it looks to not be the case, there's a jellyfin-web bit in there). Can you confirm where the web files are actually installed on your system?

The opt should 100% be working, since it's loaded as-is in the ExecStart line of the service unit:

ExecStart=/usr/bin/jellyfin ${JELLYFIN_WEB_OPT} ...

Changing it to an envvar won't fix things if it's pointing at the wrong place.

I also assume this is for 10.7.0 RC3? Or is this for a previous stable version?

Copy link
Member

@joshuaboniface joshuaboniface left a comment

See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants