Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite packet writing code for HdHomerun #5220

Merged
merged 3 commits into from Mar 13, 2021
Merged

Conversation

@Bond-009
Copy link
Member

@Bond-009 Bond-009 commented Feb 12, 2021

Removed practically every allocation (except for the string.Format ones)

Bond-009 added 2 commits Feb 12, 2021
@Bond-009 Bond-009 marked this pull request as ready for review Feb 15, 2021
@thornbill
Copy link
Member

@thornbill thornbill commented Mar 9, 2021

I tested adding, finding, and removing an HDHR tuner and playback from an HDHR tuner. All seem to work as expected. 👍

@Bond-009 Bond-009 removed the needs testing label Mar 10, 2021
@Bond-009 Bond-009 merged commit b755c25 into jellyfin:master Mar 13, 2021
12 checks passed
12 checks passed
Analyze (csharp) Analyze (csharp)
Details
CodeQL No new or fixed alerts
Details
Jellyfin Server Build #20210213.5 succeeded
Details
Jellyfin Server (Build Debug) Build Debug succeeded
Details
Jellyfin Server (Build Release) Build Release succeeded
Details
Jellyfin Server (Compatibility Check Common) Compatibility Check Common succeeded
Details
Jellyfin Server (Compatibility Check Controller) Compatibility Check Controller succeeded
Details
Jellyfin Server (Compatibility Check Model) Compatibility Check Model succeeded
Details
Jellyfin Server (Compatibility Check Naming) Compatibility Check Naming succeeded
Details
Jellyfin Server (Test Linux) Test Linux succeeded
Details
Jellyfin Server (Test Windows) Test Windows succeeded
Details
Jellyfin Server (Test macOS) Test macOS succeeded
Details
@Bond-009 Bond-009 deleted the Bond-009:hdhomerun branch Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants