Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #5168 #5278

Merged
merged 1 commit into from Feb 27, 2021
Merged

Fix for #5168 #5278

merged 1 commit into from Feb 27, 2021

Conversation

@BaronGreenback
Copy link
Contributor

@BaronGreenback BaronGreenback commented Feb 21, 2021

Credit to @rexio8 for identifying the issue.

Move code from line 173 to line 255 to ensure the correct protocol is selected..

Bug caused by stream being accessed remotely (http) and subs being based locally.
Looks like it was fixed at some point in the past, but has crept back in.

Change does include some parameter optimisations. (removing when an object and a property of an object are both passed to internal methods)

@crobibero crobibero added this to Active PRs in Release 10.7.0 via automation Feb 27, 2021
@cvium cvium merged commit 64730b5 into jellyfin:master Feb 27, 2021
12 checks passed
12 checks passed
Analyze (csharp) Analyze (csharp)
Details
CodeQL No new or fixed alerts
Details
Jellyfin Server Build #20210221.11 succeeded
Details
Jellyfin Server (Build Debug) Build Debug succeeded
Details
Jellyfin Server (Build Release) Build Release succeeded
Details
Jellyfin Server (Compatibility Check Common) Compatibility Check Common succeeded
Details
Jellyfin Server (Compatibility Check Controller) Compatibility Check Controller succeeded
Details
Jellyfin Server (Compatibility Check Model) Compatibility Check Model succeeded
Details
Jellyfin Server (Compatibility Check Naming) Compatibility Check Naming succeeded
Details
Jellyfin Server (Test Linux) Test Linux succeeded
Details
Jellyfin Server (Test Windows) Test Windows succeeded
Details
Jellyfin Server (Test macOS) Test macOS succeeded
Details
Release 10.7.0 automation moved this from Active PRs to Completed PRs Feb 27, 2021
joshuaboniface added a commit that referenced this pull request Feb 28, 2021
Fix for #5168

(cherry picked from commit 64730b5)
Signed-off-by: Joshua M. Boniface <joshua@boniface.me>
@joshuaboniface joshuaboniface moved this from Completed PRs to Jellyfinished in Release 10.7.0 Feb 28, 2021
@BaronGreenback BaronGreenback deleted the BaronGreenback:STRMFix branch Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Release 10.7.0
  
Jellyfinished
Linked issues

Successfully merging this pull request may close these issues.

5 participants