Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New UDP Subsystem #6017

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

New UDP Subsystem #6017

wants to merge 8 commits into from

Conversation

@BaronGreenback
Copy link
Contributor

@BaronGreenback BaronGreenback commented May 8, 2021

This PR is will not come into operation until later - and won't effect the current JF build at all.

Udp class based upon callbacks not thread waiting.

  • Enables low level tracing.
  • Fully IP4/IP6 compatible.
  • Fast
  • Firewall friendly
  • Create a udp server with one command and one incoming processing function.
  • Did I mention how fast it is? (I've had to put in a startup delay as it detects network devices before JF has initialised).

Have been running it happily with the DLNA, UPnP plugins.

Copy link
Member

@crobibero crobibero left a comment

I would stick MinUdpPort=1 and MaxUdpPort=65535 somewhere as constants so we can reduce the magic number usage

Jellyfin.Networking/Udp/StringExtensions.cs Outdated Show resolved Hide resolved
Jellyfin.Networking/Udp/UdpHelper.cs Outdated Show resolved Hide resolved
Jellyfin.Networking/Udp/UdpHelper.cs Outdated Show resolved Hide resolved
Jellyfin.Networking/Udp/UdpHelper.cs Outdated Show resolved Hide resolved
@crobibero
Copy link
Member

@crobibero crobibero commented May 9, 2021

Also wouldn't mind tests for the new networking code :)

BaronGreenback added a commit to BaronGreenback/jellyfin that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants