Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add switch to explicitly enable and disable dark mode #211

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

@noloman
Copy link
Contributor

@noloman noloman commented Aug 26, 2021

Simulator Screen Shot - iPhone 8 - 2021-08-26 at 12 57 45

@noloman noloman mentioned this pull request Aug 26, 2021
@mulhoon
Copy link

@mulhoon mulhoon commented Aug 26, 2021

Nice. Would there need to be 3 options... system, light and dark?
Does this still work with following the system setting?

Thanks
Nic

Loading

@noloman
Copy link
Contributor Author

@noloman noloman commented Aug 26, 2021

Nice. Would there need to be 3 options... system, light and dark?
Does this still work with following the system setting?

Thanks
Nic

Updated!

I see there's a previous commit with this feature but somewhere along the way. it was disabled and/or removed. Perhaps @weiran knows why? Thanks!

Loading

@mulhoon
Copy link

@mulhoon mulhoon commented Aug 26, 2021

Hi,
Sorry, Dark theme should probably just be Theme.

Loading

@weiran
Copy link
Owner

@weiran weiran commented Oct 22, 2021

I removed this feature a while ago when I ripped out the old theme system around iOS 13, and never tried to add it back in. @noloman I like the switch based UI for selecting the theme option here, however I've found a few bugs with your implementation:

  • the setting doesn't persist after app restart
  • the toggle itself doesn't show the right selection when you reopen the settings screen

Loading

@noloman
Copy link
Contributor Author

@noloman noloman commented Oct 23, 2021

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants