Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade various project settings #213

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

@marcusziade
Copy link

@marcusziade marcusziade commented Oct 2, 2021

This includes:

  • Newest version of Cocoapods
  • A fix for running on simulator
  • Upgraded recommended Xcode settings
  • Unify iOS 14.5 as the minimum deployment target for everything
  • Fix protocol related deprecation warnings
@marcusziade marcusziade force-pushed the upgrade-xcode-settings branch from fea6e25 to 720ca76 Oct 2, 2021
Copy link
Owner

@weiran weiran left a comment

Hi @marcusziade, thanks for the contribution. I've added a few comments to your changes. There were also other PRs merged which have caused a few conflicts with your changes.

Loading

@@ -17,9 +17,9 @@
<key>CFBundlePackageType</key>
<string>$(PRODUCT_BUNDLE_PACKAGE_TYPE)</string>
<key>CFBundleShortVersionString</key>
<string>4.6.1</string>
Copy link
Owner

@weiran weiran Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to remove version and build from these files?

Loading

@@ -109,15 +109,15 @@
/* Begin PBXCopyFilesBuildPhase section */
24C10C0124866D3F00B93F68 /* Embed App Extensions */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
buildActionMask = 8;
Copy link
Owner

@weiran weiran Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change mean? I'm not familiar with this field.

Loading

@@ -1194,7 +1194,7 @@
GCC_C_LANGUAGE_STANDARD = gnu11;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = Extensions/HackersShareExtension/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 14.0;
IPHONEOS_DEPLOYMENT_TARGET = 14.5;
Copy link
Owner

@weiran weiran Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

14.0 is the intended deployment target.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants